This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(toast): replace cancel with hide on hideDelay #3558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@cebor - plz update and dependent *.spec.js unit tests so all tests pass. |
Contributor
Author
|
@ThomasBurleson done! |
Contributor
There was a problem hiding this comment.
@rschmukler - this changes seems reasonable: hide === close.
As the author of interimElement.js, can you describe the difference [wrt interimElement] between cancel() and hide()).
Btw, a promise wrapper is also needed in hide() change is also needed:
function hide(response) {
var interimElement = stack.shift();
return $q.when(interimElement && interimElement.remove().then(function() {
interimElement.deferred.resolve(response);
}));
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
cancel()withhide()in a toast with the optionhideDelay.What it changes is, that the promise get resolved instead of rejected what makes more sense to me.